Fix R8 minify task by adding jsoup classes to proguard file#13038
Merged
TobiGr merged 1 commit intoTeamNewPipe:masterfrom Jan 11, 2026
Merged
Fix R8 minify task by adding jsoup classes to proguard file#13038TobiGr merged 1 commit intoTeamNewPipe:masterfrom
TobiGr merged 1 commit intoTeamNewPipe:masterfrom
Conversation
Member
|
I found jhy/jsoup#2459 |
This fixes the following error during the minifyWithR8 task: > Task :app:minifyReleaseWithR8 FAILED ERROR: Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /home/runner/work/NewPipe/NewPipe/app/build/outputs/mapping/release/missing_rules.txt. ERROR: R8: Missing class com.google.re2j.Matcher (referenced from: com.google.re2j.Matcher org.jsoup.helper.Re2jRegex$Re2jMatcher.delegate and 3 other contexts) Missing class com.google.re2j.Pattern (referenced from: com.google.re2j.Pattern org.jsoup.helper.Re2jRegex.re2jPattern and 4 other contexts)
4 tasks
TobiGr
added a commit
to TobiGr/NewPipe
that referenced
this pull request
Apr 20, 2026
The underlying problem is fixed with jsoup 1.12.2. See TeamNewPipe/NewPipeExtractor#1480. Revert 6c5d58b / TeamNewPipe#13038.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Question for the reviewer: Do I also need to add
-keep class org.jsoup.helper.Re2jRegex { *; }to the file?This fixes the following error during the minifyWithR8 task:
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence